HappenLee commented on code in PR #62222:
URL: https://github.com/apache/doris/pull/62222#discussion_r3207908767
##########
be/src/exec/scan/scanner_context.cpp:
##########
@@ -742,9 +718,9 @@ std::shared_ptr<ScanTask>
ScannerContext::_pull_next_scan_task(
}
if (!_pending_tasks.empty()) {
- // If shared limit quota is exhausted, do not submit new scanners from
pending queue.
- int64_t remaining =
_shared_scan_limit->load(std::memory_order_acquire);
- if (remaining == 0) {
+ // Skip submitting more pending scanners once the LIMIT budget is
+ // exhausted; they would only open and immediately EOF.
+ if (_shared_scan_limit->load(std::memory_order_acquire) == 0) {
Review Comment:
should be <= 0 like `*eof = *eof || (_shared_scan_limit &&
_shared_scan_limit->load(std::memory_order_acquire) <= 0);` the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
