sollhui opened a new pull request, #63094:
URL: https://github.com/apache/doris/pull/63094

   ### What problem does this PR solve?
   
   Problem Summary:
   
   Broker load jobs may fail after FE restart, image load, or edit log replay 
in cloud mode.
   
   `StorageDesc.storageProperties` is not persisted by Doris's Gson 
configuration, so after deserialization
   the `BrokerDesc` inside `BrokerLoadJob` can keep `storageType` and raw 
`properties` but lose the
   derived `storageProperties` object. When the pending task later tries to 
create a filesystem and list
   source files, FE cannot reconstruct the expected storage backend state and 
the load may fail with
   errors such as `Unknown storage type`.
   
   This PR fixes the issue by rebuilding `storageProperties` from 
`storageType`, `name`, and `properties`
   after Gson replay, and also lazily reinitializing it on access as a safety 
net.
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: 
https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should 
merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to