github-actions[bot] commented on code in PR #63092:
URL: https://github.com/apache/doris/pull/63092#discussion_r3212645280
##########
be/src/exprs/vcondition_expr.cpp:
##########
@@ -584,9 +584,9 @@ void insert_result_data(MutableColumnPtr& result_column,
ColumnPtr& argument_col
binary_cast<VecDateTimeValue,
int64_t>(column_raw_data[row]) *
int64_t(!(null_map_data[row] | filled_flag[row])));
} else {
- result_raw_data[row] +=
- column_raw_data[row] *
- typename ColumnType::value_type(!(null_map_data[row] |
filled_flag[row]));
+ if (!(null_map_data[row] | filled_flag[row])) {
+ result_raw_data[row] = column_raw_data[row];
Review Comment:
This bug fix needs a targeted regression test. The PR description describes
a concrete data-correctness failure where `COALESCE(nullable_double, 0)` can
return `NULL` after a null-position payload contains `NaN`, but the PR only
changes BE code and does not add a case under the existing conditional
function/coalesce tests (or a BE unit test) that fails before this change and
passes after it. Please add coverage for the nullable floating-point path so
this does not regress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
