github-actions[bot] commented on code in PR #63104:
URL: https://github.com/apache/doris/pull/63104#discussion_r3212917035
##########
be/src/exec/common/variant_util.cpp:
##########
@@ -1317,35 +1237,27 @@ void
VariantCompactionUtil::get_compaction_subcolumns_from_data_types(
inherit_column_attributes(*parent_column, sub_column);
TabletIndexes sub_column_indexes;
inherit_index(parent_indexes, sub_column_indexes, sub_column);
- if (path.get_is_typed()) {
- TabletSchema::SubColumnInfo sub_column_info {.column = sub_column,
- .indexes =
std::move(sub_column_indexes)};
- paths_set_info.typed_path_set.emplace(path.get_path(),
std::move(sub_column_info));
- } else {
- paths_set_info.subcolumn_indexes.emplace(path.get_path(),
-
std::move(sub_column_indexes));
- }
+ paths_set_info.subcolumn_indexes.emplace(path.get_path(),
std::move(sub_column_indexes));
output_schema->append_column(sub_column);
Review Comment:
This changes the helper contract for typed paths: when `path.get_is_typed()`
is true the code now records the inherited indexes in `subcolumn_indexes` and
never fills `typed_path_set`. That contradicts the existing
`get_compaction_subcolumns_from_data_types` test, which expects typed paths
such as `typed` and the typed half of `shared` to be present in
`typed_path_set` and absent from `subcolumn_indexes`. It also breaks later
typed-column index lookup in `TabletSchema::inverted_indexs(const
TabletColumn&)`, which explicitly consults `typed_path_set` for extracted typed
columns. Please preserve the previous typed-path branch here, or make the NG
caller pass only non-typed paths without changing this public helper's behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
