Mryange opened a new pull request, #63106:
URL: https://github.com/apache/doris/pull/63106
### What problem does this PR solve?
Problem Summary:
This is a follow-up to #63070, extending the thread safety annotation
migration into the pipeline executor (`be/src/exec/pipeline/`). Plain
`std::mutex` and `std::unique_lock<std::mutex>` were replaced with
`AnnotatedMutex` and `LockGuard`/`UniqueLock` wrappers from
`thread_safety_annotations.h`, enabling Clang's `-Wthread-safety` static
analysis to catch lock ordering and data race bugs at compile time.
While applying annotations, two latent data races in `debug_string()`
methods were fixed:
- `Dependency::debug_string()` and `CountedFinishDependency::debug_string()`
read `_blocked_task.size()` without holding `_task_lock`.
- `PipelineTask::debug_string()` read `_blocked_dep` and all dependency
vectors without holding `_dependency_lifecycle_lock`.
- `CountedFinishDependency::debug_string()` read `_counter` without holding
`_mtx`.
- `RuntimeFilterTimerQueue::start()` held two separate mutexes (`cv_m` +
`_que_lock`) simultaneously. Consolidated into a single `AnnotatedMutex
_que_lock` with `std::condition_variable_any` and a `UniqueLock`, eliminating
the redundant lock.
- `PriorityTaskQueue::push()` checked `_closed` before acquiring the lock —
a data race now caught because `_closed` is annotated
`GUARDED_BY(_work_size_mutex)`. Moved the `_closed` check inside the lock, and
hoisted `_compute_level()` (which doesn't touch shared state) before the lock.
- Replaced C-style `<stddef.h>`/`<stdint.h>` with `<cstddef>`/`<cstdint>`,
and removed unused includes.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
