Mryange commented on code in PR #63128:
URL: https://github.com/apache/doris/pull/63128#discussion_r3216713244
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/BuiltinAggregateFunctions.java:
##########
@@ -135,8 +137,10 @@ private BuiltinAggregateFunctions() {
agg(BoolOr.class, "bool_or", "boolor_agg"),
agg(BoolAnd.class, "bool_and", "booland_agg"),
agg(BoolXor.class, "bool_xor", "boolxor_agg"),
- agg(CollectList.class, "collect_list", "group_array"),
- agg(CollectSet.class, "collect_set", "group_uniq_array"),
+ agg(CollectList.class, "collect_list_v1"),
Review Comment:
> This makes the public `collect_list` and `group_array` names instantiate
`CollectListV2`, whose BE function name is `collect_list_v2`. During a rolling
upgrade, a new FE can plan `collect_list(...)` as `collect_list_v2` while some
BEs are still old and only register `collect_list`/`collect_set`; those
fragments will fail function lookup. The BE-side `collect_list_v1` aliases only
help new BEs accept new FE's V1 name and do not make old BEs understand V2.
Please gate the alias switch on BE capability/exec version or keep public
aliases on V1 until the cluster can guarantee all BEs support V2.
我们不会出现新fe/旧be的情况（升级过程是先升级be最后升级fe），请重新review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
