wuguowei1994 commented on PR #63118:
URL: https://github.com/apache/doris/pull/63118#issuecomment-4421947553
@eldenmoon
Thank you very much for the patient and detailed feedback.
1. I have updated the implementation to compare only the types after
removing nullable wrappers, so the predicate is applied only when the storage
type exactly matches the cast target type.
2. To reduce the risk of similar issues in the future, I also added a
negative regression test case. This should help catch unsafe cross-width type
handling earlier if related logic is changed later.
3. This patch is intentionally scoped to fixing the current production
issue with minimal risk.
In the future, I would like to improve this area further so that this
kind of type widening/conversion scenario can be supported correctly and safely.
However, that would require a larger refactor, so I prefer to keep it
out of this PR.
———
PS:
I checked the two failing CI jobs, and they do not appear to be related to
this change.
Could you please help rerun them, or skip them if appropriate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
