yujun777 commented on code in PR #62435:
URL: https://github.com/apache/doris/pull/62435#discussion_r3225170406
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/BaseAnalysisTask.java:
##########
@@ -87,10 +90,20 @@ public abstract class BaseAnalysisTask {
+ "SUBSTRING(CAST(MIN(`${colName}`) AS STRING), 1, 1024) AS
`min`, "
+ "SUBSTRING(CAST(MAX(`${colName}`) AS STRING), 1, 1024) AS
`max`, "
+ "${dataSizeFunction} AS `data_size`, "
- + "NOW() AS `update_time`, "
- + "null as `hot_value` "
- + "FROM (SELECT `${colName}`${lengthAssert} "
- + "FROM `${catalogName}`.`${dbName}`.`${tblName}` ${index})
__lc_t";
+ + "NOW() "
+ + "FROM cte1), "
+ + "cte3 AS ("
Review Comment:
Fixed in ae8282760b8. FULL_ANALYZE_TEMPLATE now mirrors the sample templates
by wrapping the cte3 GROUP_CONCAT result with IFNULL and an empty-string
fallback, so empty/all-NULL columns persist an empty hot_value string instead
of SQL NULL. I also updated the related FE UT expectations in
OlapAnalysisTaskTest and HMSAnalysisTaskTest.
Verified with:
- mvn -Pcoverage test -Dcheckstyle.skip=true -DfailIfNoTests=false
-Dmaven.build.cache.enabled=false
-Dtest=org.apache.doris.statistics.OlapAnalysisTaskTest,org.apache.doris.statistics.HMSAnalysisTaskTest
- ./run-regression-test.sh --run -d statistics -s test_hot_value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
