github-actions[bot] commented on code in PR #63194:
URL: https://github.com/apache/doris/pull/63194#discussion_r3231238319
##########
regression-test/suites/job_p0/streaming_job/cdc/test_streaming_mysql_job_metrics.groovy:
##########
@@ -200,12 +200,21 @@ suite("test_streaming_mysql_job_metrics",
metricCount++
}
+ def perJobLag = result.find {
+ it.tags?.metric ==
"doris_fe_streaming_job_per_job_lag" &&
+ it.tags?.job_name == "${jobName}"
+ }
+ if (perJobLag != null) {
+ log.info("per-job lag: ${perJobLag}".toString())
Review Comment:
This only checks that the lag metric series is present. In the final
implementation `getLagSeconds()` returns `-1` for N/A cases such as snapshot
phase or an empty/unparseable lag, and `updateStreamingJobPerJobMetrics()`
always registers the gauge, so this test would pass even if CDC lag is never
actually exposed. Please drive the job into the binlog/WAL phase and assert the
metric value is numeric and `>= 0` (or at least not `-1`) for this job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
