CalvinKirs opened a new pull request, #63211:
URL: https://github.com/apache/doris/pull/63211

   ### What problem does this PR solve?
   
   Issue Number: None
   
   Related PR: None
   
   Problem Summary: Hash distribution column validation missed JSONB and 
VARIANT columns, allowing CREATE TABLE statements such as DISTRIBUTED BY 
HASH(jsonb_col) even though those types are rejected in key and partition 
paths. This change centralizes hash distribution type validation and reuses it 
from both catalog and Nereids create-table paths.
   
   ### Release note
   
   Reject JSONB and VARIANT columns as hash distribution columns during CREATE 
TABLE analysis.
   
   ### Check List (For Author)
   
   - Test: Unit Test and Regression test attempt
       - Unit Test: env FE_UT_PARALLEL=0 ./run-fe-ut.sh --run 
org.apache.doris.nereids.trees.plans.commands.info.DistributionDescriptorTest
       - Regression test: ./run-regression-test.sh --run -d jsonb_p0 -s 
test_jsonb_distribution_column (attempted against the existing 127.0.0.1:9030 
cluster; it failed because that cluster was not rebuilt from this branch and 
still accepted HASH(JSONB), confirmed by direct mysql SHOW CREATE TABLE)
   - Behavior changed: Yes. CREATE TABLE now rejects JSONB and VARIANT hash 
distribution columns.
   - Does this need documentation: No
   
   ### What problem does this PR solve?
   
   Issue Number: close #xxx
   
   Related PR: #xxx
   
   Problem Summary:
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: 
https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should 
merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to