github-actions[bot] commented on code in PR #63182:
URL: https://github.com/apache/doris/pull/63182#discussion_r3233924807
##########
fe/fe-core/src/main/java/org/apache/doris/load/routineload/KafkaRoutineLoadJob.java:
##########
@@ -705,7 +705,9 @@ public void modifyProperties(AlterRoutineLoadCommand
command) throws UserExcepti
throw new DdlException("Only supports modification of PAUSED
jobs");
}
+ validateFlexiblePartialUpdateForAlter(jobProperties,
command.getRoutineLoadDesc());
modifyPropertiesInternal(jobProperties, dataSourceProperties);
+ setRoutineLoadDesc(command.getRoutineLoadDesc());
Review Comment:
This installs the new `RoutineLoadDesc` in memory, but the edit log written
just below still contains only `jobProperties` and `dataSourceProperties`, and
`replayModifyProperties()` only replays those two fields. Any successful `ALTER
ROUTINE LOAD ... COLUMNS/jsonpaths/...` descriptor change made here is
therefore lost on follower replay or FE restart. That also affects the new
flexible-update validation: after replay, a previously installed `COLUMNS`
descriptor can disappear, so a later transition to `UPDATE_FLEXIBLE_COLUMNS`
may validate against different state than the master had. Please persist the
altered `RoutineLoadDesc` in `AlterRoutineLoadJobOperationLog` and replay it
atomically with the property mutation, or otherwise keep descriptor
installation in a path with matching journal replay coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
