Userwhite commented on code in PR #63110:
URL: https://github.com/apache/doris/pull/63110#discussion_r3234574659
##########
be/src/storage/task/engine_publish_version_task.cpp:
##########
@@ -520,18 +528,22 @@ void AsyncTabletPublishTask::handle() {
std::lock_guard<std::mutex> wrlock(_tablet->get_rowset_update_lock());
_stats.schedule_time_us = MonotonicMicros() - _stats.submit_time_us;
std::map<TabletInfo, RowsetSharedPtr> tablet_related_rs;
- _engine.txn_manager()->get_txn_related_tablets(_transaction_id,
_partition_id,
- &tablet_related_rs);
+ std::map<TabletInfo, std::vector<RowsetSharedPtr>>
tablet_related_attach_rowsets;
+ _engine.txn_manager()->get_txn_related_tablets(
+ _transaction_id, _partition_id, &tablet_related_rs,
&tablet_related_attach_rowsets);
auto iter = tablet_related_rs.find(TabletInfo(_tablet->tablet_id(),
_tablet->tablet_uid()));
if (iter == tablet_related_rs.end()) {
return;
}
+ auto attach_rowsets_it = tablet_related_attach_rowsets.find(
+ TabletInfo(_tablet->tablet_id(), _tablet->tablet_uid()));
+ DCHECK(attach_rowsets_it != tablet_related_attach_rowsets.end());
RowsetSharedPtr rowset = iter->second;
Version version(_version, _version);
- auto publish_status =
- publish_version_and_add_rowset(_engine, _partition_id, _tablet,
rowset, _transaction_id,
- version, nullptr, _stats,
_commit_tso);
+ auto publish_status = publish_version_and_add_rowset(_engine,
_partition_id, _tablet, rowset,
+
attach_rowsets_it->second, _transaction_id,
+ version, nullptr,
_stats, _commit_tso);
Review Comment:
It can't work. `publish_version_and_add_rowset` is not function of
TabletPublishTxnTask
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
