github-actions[bot] commented on code in PR #63182:
URL: https://github.com/apache/doris/pull/63182#discussion_r3238307674
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/load/NereidsStreamLoadPlanner.java:
##########
@@ -150,6 +151,9 @@ public TPipelineFragmentParams plan(TUniqueId loadId, int
fragmentInstanceIdInde
if (uniquekeyUpdateMode ==
TUniqueKeyUpdateMode.UPDATE_FLEXIBLE_COLUMNS) {
// Validate table-level constraints for flexible partial update
destTable.validateForFlexiblePartialUpdate();
Review Comment:
This guard means the new flexible-update request-shape validation is skipped
for `NereidsRoutineLoadTaskInfo`, even though routine load uses this same
planner. `CreateRoutineLoadInfo.validateFlexiblePartialUpdate()` currently
rejects only format/fuzzy/jsonpaths/COLUMNS, so a routine load can still be
created or altered to `UPDATE_FLEXIBLE_COLUMNS` with `merge_type` DELETE/MERGE,
a `WHERE` filter, or a load-level `function_column.sequence_col`; stream load
rejects those same combinations in
`validateStreamLoadForFlexiblePartialUpdate()`. A concrete path is `CREATE
ROUTINE LOAD ... MERGE ... DELETE ON ... PROPERTIES("format"="json",
"unique_key_update_mode"="UPDATE_FLEXIBLE_COLUMNS")`: it passes routine-load
validation, plans as `NereidsRoutineLoadTaskInfo`, and never enters this
helper. Please apply the unsupported-option checks to all flexible partial
update load tasks, or add equivalent routine-load validation and regression
coverage. This is distinct from the existing stream-loa
d `merge_type=APPEND` thread because routine load bypasses the helper entirely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
