nsivarajan opened a new pull request, #63240:
URL: https://github.com/apache/doris/pull/63240
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
`SHOW CREATE TABLE` for Iceberg external tables omitted the `PARTITION BY
LIST (...) ()` clause entirely. The generated DDL was not reproducible —
running it as a new `CREATE TABLE` would create an unpartitioned table,
silently losing the partition strategy.
`Env.getDdlStmt()` for `ICEBERG_EXTERNAL_TABLE` reconstructed `ORDER BY` and
`LOCATION` from Iceberg metadata but had no code path for the partition spec.
Added `getPartitionSpecSql()` to `IcebergExternalTable`, which reads the
live `PartitionSpec` from the Iceberg catalog and converts each
`PartitionField` back to Doris DDL syntax. Wired into `Env.getDdlStmt()`
between `ORDER BY` and `LOCATION`.
*Transform mapping* (all Iceberg standard transforms covered):
- isIdentity() → col
- isBucket(n) → BUCKET(n, col)
- toString() = "truncate[n]" → TRUNCATE(n, col)
- toString() = "year/month/day/hour" → YEAR/MONTH/DAY/HOUR(col)
- isVoid() → skipped (dropped partition field from evolution)
Uses `isVoid()` and `isIdentity()` from the public `Transform` interface
where available, falls back to the spec-defined canonical `toString()`
names for remaining transforms (stable across all Iceberg versions as they are
used in metadata serialisation).
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
