github-actions[bot] commented on code in PR #63242:
URL: https://github.com/apache/doris/pull/63242#discussion_r3239788240
##########
be/src/storage/predicate/in_list_predicate.h:
##########
@@ -597,14 +597,17 @@ class InListPredicateBase final : public ColumnPredicate {
__builtin_unreachable();
}
} else {
- auto* nested_col_ptr =
-
check_and_get_column<PredicateColumnType<PredicateEvaluateType<Type>>>(column);
- if (nested_col_ptr == nullptr) {
+ const auto* nested_col =
Review Comment:
This block is not clang-formatted: the declaration is over-indented relative
to the surrounding `else` body. BE style is enforced, and this will be caught
by `build-support/clang-format.sh` / `check-format.sh`. Please run the
formatter on the changed BE C++ files.
##########
be/test/exec/sink/viceberg_delete_sink_test.cpp:
##########
@@ -441,17 +441,23 @@ TEST_F(VIcebergDeleteSinkTest,
TestBuildPositionDeleteBlock) {
ASSERT_EQ("pos", output_block.get_by_position(1).name);
// Verify file_path column
- auto file_path_column =
-
check_and_get_column<ColumnString>(output_block.get_by_position(0).column.get());
- ASSERT_NE(nullptr, file_path_column);
+ const ColumnString* file_path_column = nullptr;
Review Comment:
This added block is indented one level too far, and the assignment inside
the `if` is not indented under the block. Please run clang-format on this file
before merging.
##########
be/test/storage/index/ann/ann_range_search_test.cpp:
##########
@@ -175,8 +175,8 @@ TEST_F(VectorSearchTest, TestEvaluateAnnRangeSearch) {
doris::segment_v2::VirtualColumnIterator* virtual_column_iter =
dynamic_cast<doris::segment_v2::VirtualColumnIterator*>(column_iterators[3].get());
IColumn::Ptr column = virtual_column_iter->get_materialized_column();
- const ColumnFloat32* float_column = check_and_get_column<const
ColumnFloat32>(column.get());
- const ColumnNothing* nothing_column = check_and_get_column<const
ColumnNothing>(column.get());
+ const auto float_column = check_and_get_column<const
ColumnFloat32>(column.get());
Review Comment:
These declarations are over-indented relative to the surrounding test body.
Please run clang-format on the changed BE test files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
