morrySnow opened a new pull request, #63254:
URL: https://github.com/apache/doris/pull/63254
### What problem does this PR solve?
Issue Number: N/A
Related PR: N/A
Problem Summary:
1. When an alias function body has a cast as the outermost expression (e.g.,
`cast(n as varchar(20))`), AliasUdf.translateToNereidsFunction attempted to
cast the parsed expression to UnboundFunction, causing ClassCastException.
Fixed by changing the unboundFunction field type from UnboundFunction to
Expression so any expression can be stored.
2. Alias functions whose body contains aggregate functions, window
expressions, subqueries, or other non-scalar expressions could be created
successfully, which is incorrect. Added a containsType check in
translateToLegacyExpr that throws AnalysisException("Alias function only
supports scalar functions.") before attempting the legacy translation.
### Release note
Fix alias function creation failure when the outermost expression is a cast,
and reject alias functions containing aggregate/window/subquery expressions.
### Check List (For Author)
- Test: Unit Test (UdfTest#testAliasFunctionWithCastOutermostExpression,
UdfTest#testAliasFunctionWithIllegalExpressionsRejected)
- Behavior changed: Yes — alias functions with aggregate/window/subquery
bodies are now rejected at creation time instead of being silently accepted.
- Does this need documentation: No
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
