songsong821 opened a new pull request, #63260:
URL: https://github.com/apache/doris/pull/63260
### PR Description
#### Problem
The aws_sdk build command in build-thirdparty.sh hardcodes
`-Wno-deprecated-literal-operator` flag while also using the
`${warning_deprecated_literal_operator}` variable. This variable is only set
for GCC 15+ in the toolchain flags section. When compiling with Clang, the
hardcoded flag causes "unknown warning option" error since Clang does not
recognize this flag.
```bash
gcc_major_version=$("${CC}" -dumpversion | cut -d. -f1)
if [[ "${gcc_major_version}" -ge 15 ]]; then
warning_deprecated_literal_operator='-Wno-deprecated-literal-operator'
fi
...
-DCMAKE_CXX_FLAGS="-Wno-nonnull -Wno-deprecated-literal-operator
${warning_deprecated_literal_operator} -Wno-deprecated-declarations
${warning_dangling_reference}" -DCPP_STANDARD=17
```
#### Behavior Change
- Before: aws_sdk build fails with Clang due to unsupported
-Wno-deprecated-literal-operator warning option
- After: aws_sdk builds successfully with both GCC and Clang
#### Fix
Remove the hardcoded `-Wno-deprecated-literal-operator` flag, keeping only
the variable reference.
#### Author Checklist
- [x] aws_sdk build succeeds with GCC and Clang
- [x] No user-visible behavior change
- [x] No new tests required (build-only fix)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
