github-actions[bot] commented on code in PR #63306:
URL: https://github.com/apache/doris/pull/63306#discussion_r3248409974
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -1826,6 +1827,18 @@ private void transferToMaster() {
editLog.logMasterInfo(masterInfo);
LOG.info("logMasterInfo:{}", masterInfo);
+ if (Boolean.getBoolean(FeConstants.DROP_BACKENDS_KEY)) {
+ LOG.info("drop_backends is set, dropping all backends...");
+ for (Backend be :
Env.getCurrentSystemInfo().getAllClusterBackendsNoException().values()) {
+ try {
+ Env.getCurrentSystemInfo().dropBackend(be.getHost(),
be.getHeartbeatPort());
+ } catch (Exception e) {
Review Comment:
This catch makes `--drop_backends` succeed even when one of the requested
drops fails. For example, in cloud mode `CloudSystemInfoService.dropBackend()`
can throw if the meta-service returns a non-OK response or the backend has no
cluster id; this code logs that failure, continues with the remaining BEs, then
marks the FE ready. The result is a partially dropped cluster even though the
operator requested dropping all backends. For a destructive startup/recovery
option, a drop failure should make `transferToMaster()` fail (or collect
failures and throw after the loop) instead of continuing silently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
