github-actions[bot] commented on code in PR #63180:
URL: https://github.com/apache/doris/pull/63180#discussion_r3251652462
##########
regression-test/suites/load_p0/routine_load/test_black_list.groovy:
##########
@@ -150,5 +150,61 @@ suite("test_black_list","nonConcurrent,p0") {
GetDebugPoint().disableDebugPointForAllBEs(inject)
sql "stop routine load for ${job}"
}
+
+ def invalidBrokerTableName = "test_black_list_invalid_broker"
+ def invalidBrokerJob = "test_black_list_invalid_broker_job"
+ sql """ DROP TABLE IF EXISTS ${invalidBrokerTableName} """
+ sql """
+ CREATE TABLE IF NOT EXISTS ${invalidBrokerTableName} (
+ `k1` int(20) NULL,
+ `k2` string NULL,
+ `v1` date NULL,
+ `v2` string NULL,
+ `v3` datetime NULL,
+ `v4` string NULL
+ ) ENGINE=OLAP
+ DUPLICATE KEY(`k1`)
+ COMMENT 'OLAP'
+ DISTRIBUTED BY HASH(`k1`) BUCKETS 3
+ PROPERTIES ("replication_allocation" = "tag.location.default: 1");
+ """
+
+ try {
+ sql """
+ CREATE ROUTINE LOAD ${invalidBrokerJob} ON
${invalidBrokerTableName}
+ COLUMNS TERMINATED BY ","
+ FROM KAFKA
+ (
+ "kafka_broker_list" = "127.0.0.1:1",
Review Comment:
This regression does not exercise the stale-blacklist case fixed in
KafkaUtil. The reported NPE requires `RoutineLoadManager`'s blacklist to
contain a BE id that no longer exists in `SystemInfoService`, then a real
metadata failure causes `getInfoRequest` to fall back to blacklist entries.
This test only points an existing BE at an invalid broker and never
inserts/removes a BE to leave a stale blacklist id, so it would still pass if
the old code blindly used `getBlacklist().keySet()` in a normal environment.
Please add setup that creates a stale blacklist entry, or add a focused FE unit
test around this selection path, and assert that the original Kafka metadata
error is preserved instead of an NPE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
