github-actions[bot] commented on code in PR #63192:
URL: https://github.com/apache/doris/pull/63192#discussion_r3252831024
##########
be/src/format/parquet/delta_bit_pack_decoder.h:
##########
@@ -329,7 +329,7 @@ class DeltaByteArrayDecoder : public DeltaDecoder {
RETURN_IF_ERROR(_get_internal(_values.data(),
cast_set<uint32_t>(num_values - null_count),
&num_valid_values));
DCHECK_EQ(num_values - null_count, num_valid_values);
- if (doris_column->is_column_string()) {
+ if (doris_column->is_column_string() ||
data_type->get_primitive_type() == TYPE_VARBINARY) {
Review Comment:
This only fixes non-nullable VARBINARY. For a nullable VARBINARY column,
`ScalarColumnReader` passes `resolved_type = _converter->get_physical_type()`,
and `get_physical_column()` wraps that type in `DataTypeNullable` when the
destination slot is nullable. In that case `data_type->get_primitive_type()` is
`TYPE_NULLABLE`, and `doris_column` is a `ColumnNullable` rather than a string
column, so this branch falls through to `decode_fixed_byte_array()` and treats
the nullable column as fixed bytes. Please check
`remove_nullable(data_type)->get_primitive_type() == TYPE_VARBINARY` (or
otherwise unwrap consistently) and add a nullable DELTA_BYTE_ARRAY VARBINARY
case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
