github-actions[bot] commented on code in PR #63182:
URL: https://github.com/apache/doris/pull/63182#discussion_r3253263277
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/AlterTableCommand.java:
##########
@@ -161,6 +162,7 @@ private void rewriteAlterOpForOlapTable(ConnectContext ctx,
OlapTable table) thr
throw new AnalysisException("table " + table.getName()
+ " has enabled update flexible columns
feature already.");
}
+ table.validateVariantColumnsForFlexiblePartialUpdate();
}
Review Comment:
This enable-feature path still omits the same `light_schema_change`
requirement enforced later by `OlapTable.validateForFlexiblePartialUpdate()`. A
concrete failure path is a UNIQUE MoW table created with
`"light_schema_change"="false"`: `ALTER TABLE ... ENABLE FEATURE
"UPDATE_FLEXIBLE_COLUMNS"` passes these checks and adds the hidden skip-bitmap
column, but every later flexible partial update load is rejected at
`validateForFlexiblePartialUpdate()` because `getEnableLightSchemaChange()` is
false. Please reject the ALTER up front, or enable/require light schema change
atomically with the feature, and add a negative test for this table property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
