github-actions[bot] commented on code in PR #63192:
URL: https://github.com/apache/doris/pull/63192#discussion_r3253652966
##########
fe/fe-core/src/main/java/org/apache/doris/planner/IcebergMergeSink.java:
##########
@@ -129,6 +129,7 @@ public void bindDataSink(Optional<InsertCommandContext>
insertCtx)
if (formatVersion >= 3) {
schema = IcebergUtils.appendRowLineageFieldsForV3(schema);
}
+ IcebergUtils.validateVariantWriteUnsupported(schema);
Review Comment:
This rejects delete-only MERGE statements on Iceberg tables that contain a
VARIANT column, even though that path only needs to write delete files and does
not write VARIANT values. For example, `MERGE INTO iceberg_variant_tbl t USING
src s ON ... WHEN MATCHED THEN DELETE` now fails here because the table schema
contains VARIANT, while the semantically similar Iceberg `DELETE FROM` path
still uses `IcebergDeleteSink` and is not rejected. Please scope the VARIANT
write validation to MERGE plans that actually produce data-file rows
(UPDATE/INSERT branches), or route delete-only MERGE through the delete-only
behavior, and add coverage for a delete-only MERGE against a table with a
VARIANT column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
