mrhhsg opened a new pull request, #63355:
URL: https://github.com/apache/doris/pull/63355

   ### What problem does this PR solve?
   
   Issue Number: DORIS-25579
   
   Related PR: N/A
   
   Problem Summary: `JsonbWriter::writeKey(const char*)` inferred key length 
with `strlen`, which silently truncated byte strings that contained embedded 
NUL bytes. Remove this overload so callers must use the explicit-length API.
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test: Unit Test
       - `./run-be-ut.sh --run 
--filter=JsonbDocumentTest.*:JsonbSerializeTest.*:JsonbParserTest.*:ConvertFieldToTypeTest.*`
       - `build-support/clang-format.sh`
       - `build-support/check-format.sh`
       - `build-support/run-clang-tidy.sh --build-dir be/ut_build_ASAN` 
(failed: existing clang-tidy environment/pre-existing diagnostics report 
missing `stddef.h` and unmatched `NOLINTEND` in `be/src/core/types.h`)
   - Behavior changed: Yes. Internal C++ callers can no longer use 
`JsonbWriter::writeKey(const char*)` and must pass an explicit key length.
   - Does this need documentation: No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to