github-actions[bot] commented on code in PR #63353: URL: https://github.com/apache/doris/pull/63353#discussion_r3257710230
########## regression-test/suites/nereids_rules_p0/bind_relation/bind_view_alias_star_agg.groovy: ########## @@ -0,0 +1,52 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +suite("bind_view_alias_star_agg") { + sql "SET enable_nereids_planner=true" + sql "set runtime_filter_mode=OFF" + sql "SET enable_fallback_to_original_planner=false" + + def viewName = "bind_view_alias_star_agg" + Review Comment: Doris regression-test standards ask ordinary single test objects to use hardcoded names instead of `def tableName`-style variables, and to drop objects before use but not after the test so the environment is preserved for debugging. This case uses `def viewName` and the `finally` block drops the view after the assertion. Please hardcode `bind_view_alias_star_agg` in the SQL and remove the final drop, keeping only `DROP VIEW IF EXISTS bind_view_alias_star_agg` before creation. ########## regression-test/data/nereids_rules_p0/bind_relation/bind_view_alias_star_agg.out: ########## @@ -0,0 +1,4 @@ +-- This file is automatically generated. You should know what you did if you want to edit this +-- !select_view -- +1 2 3 4 5 1 10000 + Review Comment: The following added blank line makes `git diff --check` fail with `new blank line at EOF`. Please regenerate or trim the result file so the diff is whitespace-clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
