This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git
commit 3a40e4e12994e49f45db88d199136ecfd4abd352 Author: Xin Liao <[email protected]> AuthorDate: Mon Dec 19 14:22:25 2022 +0800 [fix](load) add to error tablets when delta writer failed to close (#15118) The result of load should be failed when all tablets delta writer failed to close on single node. But the result returned to client is success. The reason is that the committed tablets and error tablets are both empty, so publish will be success. We should add it to error tablets when delta writer failed to close, then the transaction will be failed. --- be/src/runtime/tablets_channel.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/be/src/runtime/tablets_channel.cpp b/be/src/runtime/tablets_channel.cpp index 5bee7e2050..598140eeda 100644 --- a/be/src/runtime/tablets_channel.cpp +++ b/be/src/runtime/tablets_channel.cpp @@ -118,6 +118,9 @@ Status TabletsChannel::close( if (!st.ok()) { LOG(WARNING) << "close tablet writer failed, tablet_id=" << it.first << ", transaction_id=" << _txn_id << ", err=" << st; + PTabletError* tablet_error = tablet_errors->Add(); + tablet_error->set_tablet_id(it.first); + tablet_error->set_msg(st.to_string()); // just skip this tablet(writer) and continue to close others continue; } --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
