boluor opened a new pull request, #3676:
URL: https://github.com/apache/doris-website/pull/3676

   ## Summary
   
   Two errors in the metrics doc (`admin-manual/maint-monitor/metrics.md`) for 
the `doris_fe_txn_counter` metric, both verified against the FE source 
`MetricRepo.java`:
   
   - **#14** — the `type` label is written `succes`; the metric actually emits 
`success` (`COUNTER_TXN_SUCCESS.addLabel(new MetricLabel("type", "success"))`). 
Fixed the doc typo.
   - **#15** — the `type="begin"` row was described as "Number of committed 
transactions" (Chinese: "提交的事务数量"). The `begin` counter counts begun 
transactions (FE source description: "counter of beginning transactions"); 
commit corresponds to `success`. Corrected to "Number of begun transactions" / 
"开始的事务数量". The BE metric `doris_be_stream_load_txn_request {type="begin"}` in 
the same doc already correctly says "begun".
   
   Applied across all affected versions: EN (next + 4.x) and Chinese (next + 
2.1/3.x/4.x).
   
   ## Test plan
   
   - [x] Verified the label spelling and the `begin` counter semantics against 
`apache/doris` FE `MetricRepo.java`
   - [x] Verified which versions contained each issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to