xylaaaaa commented on PR #63376: URL: https://github.com/apache/doris/pull/63376#issuecomment-4484242894
Addressed the stale/corrupt disk-entry review in `9c3212a0cd8`:\n\n- `FileMetaDiskCache::read` now invalidates the file-cache entry after verified header parse mismatch, header metadata mismatch, oversize payload metadata, or checksum mismatch. This lets the next remote read repopulate the disk cache instead of having `write` skip old DOWNLOADED blocks.\n- Payload block read miss is still treated as a plain miss and is not invalidated, to avoid deleting an entry that another thread may still be writing.\n- Added BE UT coverage for stale header refresh and corrupted-payload checksum refresh.\n\nThe old four-percent config issue was already fixed in `92eab4fce4b`; current PR head is now `9c3212a0cd8`.\n\nLocal verification:\n- `build-support/check-format.sh`\n- `git diff --check origin/master...HEAD`\n- Tried `./run-be-ut.sh --run --filter=FileMetaDiskCacheTest.* -j 8`, but local linking failed before test execution because `thirdparty/installed/lib64/libaws-cpp-sdk-kinesis.a` is mi ssing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
