liaoxin01 commented on PR #63342: URL: https://github.com/apache/doris/pull/63342#issuecomment-4488727291
### Code review Found 1 issue: 1. The new row-store pre-pass loop added to `VerticalSegmentWriter::write_batch()` creates, appends to, and finalizes the row-store column writer without invoking the disk-capacity guard, and the main column loop now skips the row-store column. As a result, `_data_dir->reach_capacity_limit(...)` is no longer enforced for the row-store column on the `TYPE_DIRECT` / `TYPE_SCHEMA_CHANGE` paths, even though the row-store column is typically the largest column written. Previously, the row-store column went through the main loop and got the same check as every other column. New pre-pass with no capacity check: https://github.com/apache/doris/blob/ac3da25a3639aee772b1eeeb95ab8b299b537797/be/src/storage/segment/vertical_segment_writer.cpp#L1028-L1045 Main-loop capacity check now unreachable for the row-store column (skipped at L1063): https://github.com/apache/doris/blob/ac3da25a3639aee772b1eeeb95ab8b299b537797/be/src/storage/segment/vertical_segment_writer.cpp#L1061-L1099 Consider adding the equivalent `reach_capacity_limit` check inside the pre-pass loop before `_finalize_column_writer_and_update_meta(cid)`. 🤖 Generated with [Claude Code](https://claude.ai/code) <sub>- If this code review was useful, please react with 👍. Otherwise, react with 👎.</sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
