Copilot commented on code in PR #63427:
URL: https://github.com/apache/doris/pull/63427#discussion_r3271121756
##########
fe/fe-core/src/main/java/org/apache/doris/job/extensions/insert/streaming/StreamingInsertJob.java:
##########
@@ -1437,6 +1437,11 @@ public void commitOffset(CommitOffsetRequest
offsetRequest) throws JobException
try {
if (this.runningStreamTask != null
&& this.runningStreamTask instanceof
StreamingMultiTblTask) {
+ if (this.runningStreamTask.getIsCanceled().get()) {
+ log.info("Streaming multi table job {} skip late commit
offset on canceled task {}",
+ getJobId(), offsetRequest.getTaskId());
+ return;
+ }
Review Comment:
The skip log can be misleading because it prints offsetRequest.getTaskId()
but the decision is based on the current runningStreamTask being canceled.
Consider logging both the running task id (expected) and the request task id
(actual), and/or checking the task-id mismatch before the canceled guard so
unexpected callbacks don’t get silently swallowed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
