github-actions[bot] commented on code in PR #63431:
URL: https://github.com/apache/doris/pull/63431#discussion_r3271342730
##########
.github/workflows/opencode-review-runner.yml:
##########
@@ -227,6 +232,17 @@ jobs:
exit 1
fi
+ - name: Persist OpenCode auth
+ if: ${{ always() && steps.configure-auth.outcome == 'success' }}
+ env:
Review Comment:
This post-review upload should not be able to fail the whole reusable
workflow after the review step has already succeeded. If `ossutil cp` has a
transient failure here, `code-review` becomes failed even though the automated
review may already have posted its result; then the caller's
`refresh-required-check` leaves the `code-review` status as `pending` because
it only marks success when `needs.code-review.result == 'success'`. That blocks
PRs on a best-effort auth persistence side effect and does not trigger the
existing review-failure comment because `steps.review.outcome` is still
`success`. Please make this step non-blocking, for example with
`continue-on-error: true` or by handling upload failures inside the script,
and/or only run it when the review itself succeeded if failed reviews should
not update the shared auth object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
