github-actions[bot] commented on code in PR #15175:
URL: https://github.com/apache/doris/pull/15175#discussion_r1052399910
##########
be/test/exec/plain_text_line_reader_lzop_test.cpp:
##########
@@ -205,15 +213,17 @@ TEST_F(PlainTextLineReaderTest, lzop_test_limit4) {
}
TEST_F(PlainTextLineReaderTest, lzop_test_limit5) {
- LocalFileReader
file_reader("./be/test/exec/test_data/plain_text_line_reader/limit.csv.lzo", 0);
- auto st = file_reader.open();
+ io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+ io::FileReaderSPtr file_reader;
+ auto st =
local_fs->open_file("./be/test/exec/test_data/plain_text_line_reader/limit.csv.lzo",
+ &file_reader);
EXPECT_TRUE(st.ok());
Decompressor* decompressor;
st = Decompressor::create_decompressor(CompressType::LZOP, &decompressor);
EXPECT_TRUE(st.ok());
- PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, 0,
"\n", 1);
+ NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor,
0, "\n", 1, 0);
Review Comment:
warning: '_profile' is a private member of 'doris::PlainTextLineReaderTest'
[clang-diagnostic-error]
```cpp
NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor,
0, "\n", 1, 0);
^
```
**be/test/exec/plain_text_line_reader_lzop_test.cpp:34:** declared private
here
```cpp
RuntimeProfile _profile;
^
```
##########
be/test/exec/plain_text_line_reader_uncompressed_test.cpp:
##########
@@ -88,17 +90,18 @@
}
TEST_F(PlainTextLineReaderUncompressedTest, uncompressed_no_newline) {
- LocalFileReader
file_reader("./be/test/exec/test_data/plain_text_line_reader/no_newline.csv",
- 0);
- auto st = file_reader.open();
+ io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+ io::FileReaderSPtr file_reader;
+ auto st =
local_fs->open_file("./be/test/exec/test_data/plain_text_line_reader/no_newline.csv",
+ &file_reader);
EXPECT_TRUE(st.ok());
Decompressor* decompressor;
st = Decompressor::create_decompressor(CompressType::UNCOMPRESSED,
&decompressor);
EXPECT_TRUE(st.ok());
EXPECT_TRUE(decompressor == nullptr);
- PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, -1,
"\n", 1);
+ NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor,
-1, "\n", 1, 0);
Review Comment:
warning: '_profile' is a private member of
'doris::PlainTextLineReaderUncompressedTest' [clang-diagnostic-error]
```cpp
NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor,
-1, "\n", 1, 0);
^
```
**be/test/exec/plain_text_line_reader_uncompressed_test.cpp:35:** declared
private here
```cpp
RuntimeProfile _profile;
^
```
##########
be/test/exec/plain_text_line_reader_uncompressed_test.cpp:
##########
@@ -124,16 +127,18 @@
}
TEST_F(PlainTextLineReaderUncompressedTest, uncompressed_test_limit) {
- LocalFileReader
file_reader("./be/test/exec/test_data/plain_text_line_reader/limit.csv", 0);
- auto st = file_reader.open();
+ io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+ io::FileReaderSPtr file_reader;
+ auto st =
local_fs->open_file("./be/test/exec/test_data/plain_text_line_reader/limit.csv",
+ &file_reader);
EXPECT_TRUE(st.ok());
Decompressor* decompressor;
st = Decompressor::create_decompressor(CompressType::UNCOMPRESSED,
&decompressor);
EXPECT_TRUE(st.ok());
EXPECT_TRUE(decompressor == nullptr);
- PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, 8,
"\n", 1);
+ NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor,
8, "\n", 1, 0);
Review Comment:
warning: '_profile' is a private member of
'doris::PlainTextLineReaderUncompressedTest' [clang-diagnostic-error]
```cpp
NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor,
8, "\n", 1, 0);
^
```
**be/test/exec/plain_text_line_reader_uncompressed_test.cpp:35:** declared
private here
```cpp
RuntimeProfile _profile;
^
```
##########
be/test/exec/plain_text_line_reader_uncompressed_test.cpp:
##########
@@ -37,16 +37,18 @@ class PlainTextLineReaderUncompressedTest : public
testing::Test {
};
TEST_F(PlainTextLineReaderUncompressedTest, uncompressed_normal_use) {
- LocalFileReader
file_reader("./be/test/exec/test_data/plain_text_line_reader/test_file.csv", 0);
- auto st = file_reader.open();
+ io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+ io::FileReaderSPtr file_reader;
+ auto st =
local_fs->open_file("./be/test/exec/test_data/plain_text_line_reader/test_file.csv",
+ &file_reader);
EXPECT_TRUE(st.ok());
Decompressor* decompressor;
st = Decompressor::create_decompressor(CompressType::UNCOMPRESSED,
&decompressor);
EXPECT_TRUE(st.ok());
EXPECT_TRUE(decompressor == nullptr);
- PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, -1,
"\n", 1);
+ NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor,
-1, "\n", 1, 0);
Review Comment:
warning: '_profile' is a private member of
'doris::PlainTextLineReaderUncompressedTest' [clang-diagnostic-error]
```cpp
NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor,
-1, "\n", 1, 0);
^
```
**be/test/exec/plain_text_line_reader_uncompressed_test.cpp:35:** declared
private here
```cpp
RuntimeProfile _profile;
^
```
##########
be/test/exec/plain_text_line_reader_uncompressed_test.cpp:
##########
@@ -280,7 +295,7 @@
EXPECT_TRUE(decompressor == nullptr);
// set min length larger than 0 to test
- PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, 10,
"\n", 1);
+ NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor,
10, "\n", 1, 0);
Review Comment:
warning: '_profile' is a private member of
'doris::PlainTextLineReaderUncompressedTest' [clang-diagnostic-error]
```cpp
NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor,
10, "\n", 1, 0);
^
```
**be/test/exec/plain_text_line_reader_uncompressed_test.cpp:35:** declared
private here
```cpp
RuntimeProfile _profile;
^
```
##########
be/test/exec/plain_text_line_reader_uncompressed_test.cpp:
##########
@@ -218,16 +227,18 @@
}
TEST_F(PlainTextLineReaderUncompressedTest, uncompressed_test_limit4) {
- LocalFileReader
file_reader("./be/test/exec/test_data/plain_text_line_reader/limit.csv", 0);
- auto st = file_reader.open();
+ io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+ io::FileReaderSPtr file_reader;
+ auto st =
local_fs->open_file("./be/test/exec/test_data/plain_text_line_reader/limit.csv",
+ &file_reader);
EXPECT_TRUE(st.ok());
Decompressor* decompressor;
st = Decompressor::create_decompressor(CompressType::UNCOMPRESSED,
&decompressor);
EXPECT_TRUE(st.ok());
EXPECT_TRUE(decompressor == nullptr);
- PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, 7,
"\n", 1);
+ NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor,
7, "\n", 1, 0);
Review Comment:
warning: '_profile' is a private member of
'doris::PlainTextLineReaderUncompressedTest' [clang-diagnostic-error]
```cpp
NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor,
7, "\n", 1, 0);
^
```
**be/test/exec/plain_text_line_reader_uncompressed_test.cpp:35:** declared
private here
```cpp
RuntimeProfile _profile;
^
```
##########
be/test/exec/plain_text_line_reader_uncompressed_test.cpp:
##########
@@ -249,16 +260,18 @@
}
TEST_F(PlainTextLineReaderUncompressedTest, uncompressed_test_limit5) {
- LocalFileReader
file_reader("./be/test/exec/test_data/plain_text_line_reader/limit.csv", 0);
- auto st = file_reader.open();
+ io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+ io::FileReaderSPtr file_reader;
+ auto st =
local_fs->open_file("./be/test/exec/test_data/plain_text_line_reader/limit.csv",
+ &file_reader);
EXPECT_TRUE(st.ok());
Decompressor* decompressor;
st = Decompressor::create_decompressor(CompressType::UNCOMPRESSED,
&decompressor);
EXPECT_TRUE(st.ok());
EXPECT_TRUE(decompressor == nullptr);
- PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, 0,
"\n", 1);
+ NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor,
0, "\n", 1, 0);
Review Comment:
warning: '_profile' is a private member of
'doris::PlainTextLineReaderUncompressedTest' [clang-diagnostic-error]
```cpp
NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor,
0, "\n", 1, 0);
^
```
**be/test/exec/plain_text_line_reader_uncompressed_test.cpp:35:** declared
private here
```cpp
RuntimeProfile _profile;
^
```
##########
be/test/exec/tablet_sink_test.cpp:
##########
@@ -52,7 +51,6 @@
_env = ExecEnv::GetInstance();
_env->_thread_mgr = new ThreadResourceMgr();
_env->_master_info = new TMasterInfo();
- _env->_load_stream_mgr = new LoadStreamMgr();
_env->_internal_client_cache = new
BrpcClientCache<PBackendService_Stub>();
_env->_function_client_cache = new
BrpcClientCache<PFunctionService_Stub>();
Review Comment:
warning: '_function_client_cache' is a private member of 'doris::ExecEnv'
[clang-diagnostic-error]
```cpp
_env->_function_client_cache = new
BrpcClientCache<PFunctionService_Stub>();
^
```
**be/src/runtime/exec_env.h:256:** declared private here
```cpp
BrpcClientCache<PFunctionService_Stub>* _function_client_cache = nullptr;
^
```
##########
be/test/runtime/routine_load_task_executor_test.cpp:
##########
@@ -58,8 +58,8 @@
void TearDown() override {
delete _env._master_info;
_env._master_info = nullptr;
Review Comment:
warning: '_master_info' is a private member of 'doris::ExecEnv'
[clang-diagnostic-error]
```cpp
_env._master_info = nullptr;
^
```
**be/src/runtime/exec_env.h:245:** declared private here
```cpp
TMasterInfo* _master_info = nullptr;
^
```
##########
be/test/exec/plain_text_line_reader_lzop_test.cpp:
##########
@@ -224,16 +234,17 @@
}
TEST_F(PlainTextLineReaderTest, lzop_test_larger) {
- LocalFileReader
file_reader("./be/test/exec/test_data/plain_text_line_reader/larger.txt.lzo",
- 0);
- auto st = file_reader.open();
+ io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+ io::FileReaderSPtr file_reader;
+ auto st =
local_fs->open_file("./be/test/exec/test_data/plain_text_line_reader/larger.txt.lzo",
+ &file_reader);
EXPECT_TRUE(st.ok());
Decompressor* decompressor;
st = Decompressor::create_decompressor(CompressType::LZOP, &decompressor);
EXPECT_TRUE(st.ok());
- PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, -1,
"\n", 1);
+ NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor,
-1, "\n", 1, 0);
Review Comment:
warning: '_profile' is a private member of 'doris::PlainTextLineReaderTest'
[clang-diagnostic-error]
```cpp
NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor,
-1, "\n", 1, 0);
^
```
**be/test/exec/plain_text_line_reader_lzop_test.cpp:34:** declared private
here
```cpp
RuntimeProfile _profile;
^
```
##########
be/test/runtime/routine_load_task_executor_test.cpp:
##########
@@ -58,8 +58,8 @@
void TearDown() override {
delete _env._master_info;
Review Comment:
warning: '_master_info' is a private member of 'doris::ExecEnv'
[clang-diagnostic-error]
```cpp
delete _env._master_info;
^
```
**be/src/runtime/exec_env.h:245:** declared private here
```cpp
TMasterInfo* _master_info = nullptr;
^
```
##########
be/test/runtime/routine_load_task_executor_test.cpp:
##########
@@ -48,7 +48,7 @@
k_stream_load_put_result = TStreamLoadPutResult();
_env._master_info = new TMasterInfo();
- _env._load_stream_mgr = new LoadStreamMgr();
+ _env._new_load_stream_mgr = new NewLoadStreamMgr();
_env._stream_load_executor = new StreamLoadExecutor(&_env);
Review Comment:
warning: '_stream_load_executor' is a private member of 'doris::ExecEnv'
[clang-diagnostic-error]
```cpp
_env._stream_load_executor = new StreamLoadExecutor(&_env);
^
```
**be/src/runtime/exec_env.h:262:** declared private here
```cpp
StreamLoadExecutor* _stream_load_executor = nullptr;
^
```
##########
be/test/runtime/routine_load_task_executor_test.cpp:
##########
@@ -58,8 +58,8 @@
void TearDown() override {
delete _env._master_info;
_env._master_info = nullptr;
- delete _env._load_stream_mgr;
- _env._load_stream_mgr = nullptr;
+ delete _env._new_load_stream_mgr;
+ _env._new_load_stream_mgr = nullptr;
Review Comment:
warning: '_new_load_stream_mgr' is a private member of 'doris::ExecEnv'
[clang-diagnostic-error]
```cpp
_env._new_load_stream_mgr = nullptr;
^
```
**be/src/runtime/exec_env.h:254:** declared private here
```cpp
NewLoadStreamMgr* _new_load_stream_mgr = nullptr;
^
```
##########
be/test/runtime/routine_load_task_executor_test.cpp:
##########
@@ -58,8 +58,8 @@
void TearDown() override {
delete _env._master_info;
_env._master_info = nullptr;
- delete _env._load_stream_mgr;
- _env._load_stream_mgr = nullptr;
+ delete _env._new_load_stream_mgr;
Review Comment:
warning: '_new_load_stream_mgr' is a private member of 'doris::ExecEnv'
[clang-diagnostic-error]
```cpp
delete _env._new_load_stream_mgr;
^
```
**be/src/runtime/exec_env.h:254:** declared private here
```cpp
NewLoadStreamMgr* _new_load_stream_mgr = nullptr;
^
```
##########
be/test/exec/plain_text_line_reader_uncompressed_test.cpp:
##########
@@ -161,16 +166,18 @@
}
TEST_F(PlainTextLineReaderUncompressedTest, uncompressed_test_limit2) {
- LocalFileReader
file_reader("./be/test/exec/test_data/plain_text_line_reader/limit.csv", 0);
- auto st = file_reader.open();
+ io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+ io::FileReaderSPtr file_reader;
+ auto st =
local_fs->open_file("./be/test/exec/test_data/plain_text_line_reader/limit.csv",
+ &file_reader);
EXPECT_TRUE(st.ok());
Decompressor* decompressor;
st = Decompressor::create_decompressor(CompressType::UNCOMPRESSED,
&decompressor);
EXPECT_TRUE(st.ok());
EXPECT_TRUE(decompressor == nullptr);
- PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, 6,
"\n", 1);
+ NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor,
6, "\n", 1, 0);
Review Comment:
warning: '_profile' is a private member of
'doris::PlainTextLineReaderUncompressedTest' [clang-diagnostic-error]
```cpp
NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor,
6, "\n", 1, 0);
^
```
**be/test/exec/plain_text_line_reader_uncompressed_test.cpp:35:** declared
private here
```cpp
RuntimeProfile _profile;
^
```
##########
be/test/exec/plain_text_line_reader_uncompressed_test.cpp:
##########
@@ -196,7 +205,7 @@
EXPECT_TRUE(st.ok());
EXPECT_TRUE(decompressor == nullptr);
- PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, 7,
"\n", 1);
+ NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor,
7, "\n", 1, 0);
Review Comment:
warning: '_profile' is a private member of
'doris::PlainTextLineReaderUncompressedTest' [clang-diagnostic-error]
```cpp
NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor,
7, "\n", 1, 0);
^
```
**be/test/exec/plain_text_line_reader_uncompressed_test.cpp:35:** declared
private here
```cpp
RuntimeProfile _profile;
^
```
##########
be/test/exec/tablet_sink_test.cpp:
##########
@@ -52,7 +51,6 @@
_env = ExecEnv::GetInstance();
_env->_thread_mgr = new ThreadResourceMgr();
_env->_master_info = new TMasterInfo();
Review Comment:
warning: '_master_info' is a private member of 'doris::ExecEnv'
[clang-diagnostic-error]
```cpp
_env->_master_info = new TMasterInfo();
^
```
**be/src/runtime/exec_env.h:245:** declared private here
```cpp
TMasterInfo* _master_info = nullptr;
^
```
##########
be/test/runtime/routine_load_task_executor_test.cpp:
##########
@@ -48,7 +48,7 @@ class RoutineLoadTaskExecutorTest : public testing::Test {
k_stream_load_put_result = TStreamLoadPutResult();
_env._master_info = new TMasterInfo();
Review Comment:
warning: '_master_info' is a private member of 'doris::ExecEnv'
[clang-diagnostic-error]
```cpp
_env._master_info = new TMasterInfo();
^
```
**be/src/runtime/exec_env.h:245:** declared private here
```cpp
TMasterInfo* _master_info = nullptr;
^
```
##########
be/test/exec/tablet_sink_test.cpp:
##########
@@ -67,7 +65,6 @@
void TearDown() override {
SAFE_DELETE(_env->_internal_client_cache);
SAFE_DELETE(_env->_function_client_cache);
Review Comment:
warning: '_function_client_cache' is a private member of 'doris::ExecEnv'
[clang-diagnostic-error]
```cpp
SAFE_DELETE(_env->_function_client_cache);
^
```
**be/src/runtime/exec_env.h:256:** declared private here
```cpp
BrpcClientCache<PFunctionService_Stub>* _function_client_cache = nullptr;
^
```
##########
be/test/exec/tablet_sink_test.cpp:
##########
@@ -67,7 +65,6 @@
void TearDown() override {
SAFE_DELETE(_env->_internal_client_cache);
Review Comment:
warning: '_internal_client_cache' is a private member of 'doris::ExecEnv'
[clang-diagnostic-error]
```cpp
SAFE_DELETE(_env->_internal_client_cache);
^
```
**be/src/runtime/exec_env.h:255:** declared private here
```cpp
BrpcClientCache<PBackendService_Stub>* _internal_client_cache = nullptr;
^
```
##########
be/test/exec/tablet_sink_test.cpp:
##########
@@ -52,7 +51,6 @@ class OlapTableSinkTest : public testing::Test {
_env = ExecEnv::GetInstance();
_env->_thread_mgr = new ThreadResourceMgr();
Review Comment:
warning: '_thread_mgr' is a private member of 'doris::ExecEnv'
[clang-diagnostic-error]
```cpp
_env->_thread_mgr = new ThreadResourceMgr();
^
```
**be/src/runtime/exec_env.h:209:** declared private here
```cpp
ThreadResourceMgr* _thread_mgr = nullptr;
^
```
##########
be/test/exec/tablet_sink_test.cpp:
##########
@@ -67,7 +65,6 @@
void TearDown() override {
SAFE_DELETE(_env->_internal_client_cache);
SAFE_DELETE(_env->_function_client_cache);
- SAFE_DELETE(_env->_load_stream_mgr);
SAFE_DELETE(_env->_master_info);
Review Comment:
warning: '_master_info' is a private member of 'doris::ExecEnv'
[clang-diagnostic-error]
```cpp
SAFE_DELETE(_env->_master_info);
^
```
**be/src/runtime/exec_env.h:245:** declared private here
```cpp
TMasterInfo* _master_info = nullptr;
^
```
##########
be/test/exec/tablet_sink_test.cpp:
##########
@@ -52,7 +51,6 @@
_env = ExecEnv::GetInstance();
_env->_thread_mgr = new ThreadResourceMgr();
_env->_master_info = new TMasterInfo();
- _env->_load_stream_mgr = new LoadStreamMgr();
_env->_internal_client_cache = new
BrpcClientCache<PBackendService_Stub>();
Review Comment:
warning: '_internal_client_cache' is a private member of 'doris::ExecEnv'
[clang-diagnostic-error]
```cpp
_env->_internal_client_cache = new
BrpcClientCache<PBackendService_Stub>();
^
```
**be/src/runtime/exec_env.h:255:** declared private here
```cpp
BrpcClientCache<PBackendService_Stub>* _internal_client_cache = nullptr;
^
```
##########
be/test/exec/tablet_sink_test.cpp:
##########
@@ -67,7 +65,6 @@
void TearDown() override {
SAFE_DELETE(_env->_internal_client_cache);
SAFE_DELETE(_env->_function_client_cache);
- SAFE_DELETE(_env->_load_stream_mgr);
SAFE_DELETE(_env->_master_info);
SAFE_DELETE(_env->_thread_mgr);
Review Comment:
warning: '_thread_mgr' is a private member of 'doris::ExecEnv'
[clang-diagnostic-error]
```cpp
SAFE_DELETE(_env->_thread_mgr);
^
```
**be/src/runtime/exec_env.h:209:** declared private here
```cpp
ThreadResourceMgr* _thread_mgr = nullptr;
^
```
##########
be/test/runtime/routine_load_task_executor_test.cpp:
##########
@@ -48,7 +48,7 @@
k_stream_load_put_result = TStreamLoadPutResult();
_env._master_info = new TMasterInfo();
- _env._load_stream_mgr = new LoadStreamMgr();
+ _env._new_load_stream_mgr = new NewLoadStreamMgr();
Review Comment:
warning: '_new_load_stream_mgr' is a private member of 'doris::ExecEnv'
[clang-diagnostic-error]
```cpp
_env._new_load_stream_mgr = new NewLoadStreamMgr();
^
```
**be/src/runtime/exec_env.h:254:** declared private here
```cpp
NewLoadStreamMgr* _new_load_stream_mgr = nullptr;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
