JNSimba commented on code in PR #63480:
URL: https://github.com/apache/doris/pull/63480#discussion_r3279942875
##########
fe/fe-core/src/main/java/org/apache/doris/tablefunction/CdcStreamTableValuedFunction.java:
##########
@@ -118,6 +118,26 @@ private void validate(Map<String, String> properties)
throws AnalysisException {
if (!properties.containsKey(DataSourceConfigKeys.OFFSET)) {
throw new AnalysisException("offset is required");
}
Review Comment:
Tightened the four required-field checks to
`StringUtils.isEmpty(properties.get(...))` for `jdbc_url` / `type` / `table` /
`offset` in 0ec02e1ae2. Also added a regression case with `"type"=""` in
`test_cdc_stream_tvf_mysql.groovy` to lock in the clearer `type is required`
error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
