Copilot commented on code in PR #63497:
URL: https://github.com/apache/doris/pull/63497#discussion_r3281745257
##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -3574,7 +3574,7 @@ static bool remove_pending_delete_bitmap(MetaServiceCode&
code, std::string& msg
// delete delete bitmap of expired txn
PendingDeleteBitmapPB pending_info;
- if (!pending_info.ParseFromString(pending_val)) [[unlikely]] {
+ if (!pending_val_buf.to_pb(&pending_info)) [[unlikely]] {
code = MetaServiceCode::PROTOBUF_PARSE_ERR;
msg = "failed to parse PendingDeleteBitmapPB";
Review Comment:
The cleanup path for pending delete bitmaps still relies on manually
range-deleting split values (constructing end_key with
encode_int64(INT64_MAX)). Since cloud::blob_remove() now exists for exactly
this purpose, consider using it for delete_bitmap_key cleanup too to avoid
duplicating the split-value implementation details (and to align with the
nearby FIXME about not exposing those details).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
