github-actions[bot] commented on code in PR #63234:
URL: https://github.com/apache/doris/pull/63234#discussion_r3286482343
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/DatasourcePrintableMap.java:
##########
@@ -58,6 +59,7 @@ public class DatasourcePrintableMap<K, V> extends
BasicPrintableMap<K, V> {
SENSITIVE_KEY.addAll(ConnectorPropertiesUtils.getSensitiveKeys(S3Properties.class));
SENSITIVE_KEY.addAll(ConnectorPropertiesUtils.getSensitiveKeys(AliyunDLFBaseProperties.class));
SENSITIVE_KEY.addAll(ConnectorPropertiesUtils.getSensitiveKeys(AWSGlueMetaStoreBaseProperties.class));
+
SENSITIVE_KEY.addAll(ConnectorPropertiesUtils.getSensitiveKeys(IcebergRestProperties.class));
SENSITIVE_KEY.addAll(ConnectorPropertiesUtils.getSensitiveKeys(GCSProperties.class));
Review Comment:
This registers Iceberg REST keys only if they are marked `sensitive` in
`IcebergRestProperties`. The OAuth2 token path is a parallel supported
authentication mode (`iceberg.rest.oauth2.token`), but that property is not
marked sensitive, so a catalog created with a bearer token instead of
`iceberg.rest.oauth2.credential` will still have the raw token printed by `SHOW
CREATE CATALOG`. Please mark the token property sensitive as well and add
coverage for the token case, otherwise this fix only closes one of the two
OAuth2 secret paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
