boluor opened a new pull request, #3746:
URL: https://github.com/apache/doris-website/pull/3746

   ## Summary
   
   Fixes #3463. The fe-config doc for `default_compression_type` had two 
factual errors:
   
   1. **Default value** — doc said `lz4` (before 4.0.3) / `zstd` (since 4.0.3). 
The actual FE Config in apache/doris is `LZ4F` (before 4.0.3) and `ZSTD` (since 
4.0.3). The default was changed by apache/doris#58923 (label 
`dev/4.0.3-merged`) — "[opt](compression) change default compression from lz4f 
to zstd". `LZ4` and `LZ4F` are different algorithms (raw block vs frame 
format), so the previous `lz4` was simply wrong.
   
   2. **Valid values** — doc said "lz4, zstd". The `Config.java` description 
and `PropertyAnalyzer.stringToCompressionType` actually accept seven 
algorithms: `LZ4`, `LZ4F`, `LZ4HC`, `ZLIB`, `ZSTD`, `SNAPPY`, `NONE` 
(case-insensitive).
   
   Source-of-truth references:
   - `fe/fe-common/src/main/java/org/apache/doris/common/Config.java` 
(`default_compression_type` field, both pre-58923 and post-58923 values)
   - 
`fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java#stringToCompressionType`
 (accepted values)
   
   ## Scope
   
   Updated in 4 places (current/dev EN + zh, 4.x EN + zh):
   - `docs/admin-manual/config/fe-config.md`
   - 
`i18n/zh-CN/docusaurus-plugin-content-docs/current/admin-manual/config/fe-config.md`
   - `versioned_docs/version-4.x/admin-manual/config/fe-config.md`
   - 
`i18n/zh-CN/docusaurus-plugin-content-docs/version-4.x/admin-manual/config/fe-config.md`
   
   The parameter does not exist in `branch-2.1` or `branch-3.0`, so the 2.1 
docs need no change.
   
   ## Test plan
   
   - [x] Each touched page shows the corrected default (`LZ4F` / `ZSTD`) and 
the full valid-values list
   - [x] Dead-link check passes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to