Copilot commented on code in PR #63554:
URL: https://github.com/apache/doris/pull/63554#discussion_r3292022070
##########
regression-test/suites/external_table_p0/paimon/test_paimon_gcs.groovy:
##########
@@ -32,6 +32,7 @@ suite("test_paimon_gcs",
"p0,external,doris,new_catalog_property") {
CREATE CATALOG ${catalog_name} PROPERTIES (
'type' = 'paimon',
'warehouse' = '${gcs_warehouse}',
+ 'fs.gcs.support' = 'true',
Review Comment:
The same property line is duplicated across both catalog definitions.
Consider extracting the shared catalog properties into a single reusable
string/template (or a helper method) to reduce duplication and prevent future
drift if properties change (e.g., adding/removing common keys).
##########
regression-test/suites/external_table_p0/paimon/test_paimon_gcs.groovy:
##########
@@ -57,6 +58,7 @@ suite("test_paimon_gcs",
"p0,external,doris,new_catalog_property") {
CREATE CATALOG ${catalog_name}_with_region PROPERTIES (
'type' = 'paimon',
'warehouse' = '${gcs_warehouse}',
+ 'fs.gcs.support' = 'true',
Review Comment:
The same property line is duplicated across both catalog definitions.
Consider extracting the shared catalog properties into a single reusable
string/template (or a helper method) to reduce duplication and prevent future
drift if properties change (e.g., adding/removing common keys).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
