github-actions[bot] commented on code in PR #63468:
URL: https://github.com/apache/doris/pull/63468#discussion_r3301697098
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/AccessPathExpressionCollector.java:
##########
@@ -114,6 +114,10 @@ public Void visit(Expression expr, CollectorContext
context) {
@Override
public Void visitSlotReference(SlotReference slotReference,
CollectorContext context) {
DataType dataType = slotReference.getDataType();
+ if (isFunctionNullCheckPath(context.accessPathBuilder.getPathList())
Review Comment:
This changes access-path collection for `IS NULL` / `IS NOT NULL` when the
underlying column is physically non-nullable, but the PR does not add a test
for the new branch. Existing `PruneNestedColumnTest` coverage exercises
nullable null-only paths, not a `VARIANT NOT NULL` or other physically
non-nullable column proving that `[col, NULL]` is skipped while nullable
columns still emit it. Please add coverage for the intended case and a nullable
control case so this pruning behavior cannot regress silently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
