CalvinKirs commented on code in PR #63481:
URL: https://github.com/apache/doris/pull/63481#discussion_r3303522919
##########
fe/fe-catalog/pom.xml:
##########
@@ -53,6 +53,12 @@ under the License.
<groupId>org.apache.commons</groupId>
<artifactId>commons-collections4</artifactId>
</dependency>
+ <!--
https://mvnrepository.com/artifact/com.googlecode.java-ipv6/java-ipv6 -->
+ <dependency>
+ <groupId>com.googlecode.java-ipv6</groupId>
+ <artifactId>java-ipv6</artifactId>
+ <version>0.17</version>
Review Comment:
I ’d avoid introducing java-ipv6; it doesn’t seem to be actively maintained,
with the last release dating back about eight years. For basic IP literal
parsing and validation, Guava’s InetAddresses should be enough. If we need
CIDR, subnet, or address-range handling, we should pick a more actively
maintained and fully featured IP address library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
