github-actions[bot] commented on code in PR #63528:
URL: https://github.com/apache/doris/pull/63528#discussion_r3308877790
##########
be/src/core/data_type_serde/complex_type_deserialize_util.h:
##########
@@ -15,6 +15,7 @@
// specific language governing permissions and limitations
// under the License.
+#include "core/data_type_serde/data_type_nullable_serde.h"
#include "core/data_type_serde/data_type_serde.h"
#include "core/string_ref.h"
Review Comment:
This nested NULL check is case-sensitive, but FE validates the default by
parsing the string as a SQL expression, where `NULL` is case-insensitive. For
example, `ARRAY<INT> DEFAULT '[NULL]'` is accepted by
`isLiteralDefaultValue(ArrayLiteral.class)`, but when an older rowset/default
iterator materializes it here, `is_null_string("NULL")` returns false, the
nullable serde is unwrapped, and the INT parser fails with `parse number fail`.
Please make this helper recognize `NULL` case-insensitively and add regression
coverage for uppercase/mixed-case nested NULL defaults in ARRAY/MAP/STRUCT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
