mrhhsg commented on code in PR #63528:
URL: https://github.com/apache/doris/pull/63528#discussion_r3314309503


##########
be/src/storage/segment/segment.cpp:
##########
@@ -659,10 +659,11 @@ Status Segment::new_default_iterator(const TabletColumn& 
tablet_column,
                 "column_type={}",
                 tablet_column.unique_id(), tablet_column.name(), 
tablet_column.type());
     }
+    auto serde = remove_nullable(tablet_column.get_vec_type())->get_serde();

Review Comment:
   Addressed in 08b4e4987e5. `SchemaChangeJob::_init_column_mapping()` now 
parses explicit defaults with 
`remove_nullable(column_schema.get_vec_type())->get_serde()`, matching the 
default-iterator path so nullable complex schema-change defaults with 
type-mismatched ARRAY/MAP/STRUCT values are rejected instead of being 
materialized as NULL. Added regression coverage for the direct schema-change 
path with invalid nullable ARRAY/MAP/STRUCT defaults.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to