Gabriel39 opened a new pull request, #63825:
URL: https://github.com/apache/doris/pull/63825
### What problem does this PR solve?
Issue Number: close #26033
Related PR: None
Problem Summary: Creating an Iceberg table with format-version 3 could
accept user columns named _row_id or _last_updated_sequence_number. Doris later
appends Iceberg row lineage hidden columns with the same names, which can
produce duplicate hidden-column metadata and confusing insert/query behavior.
This change validates Iceberg create table definitions, including CTAS, and
rejects those reserved row lineage column names when the requested Iceberg
format version is 3 or newer.
### Release note
Reject reserved Iceberg v3 row lineage column names when creating Iceberg
tables.
### Check List (For Author)
- Test: Unit Test
- Added IcebergDDLAndDMLPlanTest coverage for CREATE TABLE and CTAS
validation.
- Ran git diff --check and git diff --cached --check.
- Could not run ./run-fe-ut.sh --run
org.apache.doris.datasource.iceberg.IcebergDDLAndDMLPlanTest because JAVA_HOME
points to JDK 11 and JDK_17 is unset.
- Could not run build-support/check-format.sh because clang-format is
not installed.
- Behavior changed: Yes. Iceberg v3 CREATE TABLE now rejects user columns
named _row_id and _last_updated_sequence_number.
- Does this need documentation: No
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
