github-actions[bot] commented on code in PR #60944:
URL: https://github.com/apache/doris/pull/60944#discussion_r3321845912
##########
fe/fe-core/src/main/java/org/apache/doris/common/proc/ColocationGroupBackendSeqsProcNode.java:
##########
@@ -39,26 +39,26 @@ public ColocationGroupBackendSeqsProcNode(Map<Tag,
List<List<Long>>> backendsSeq
@Override
public ProcResult fetchResult() throws AnalysisException {
BaseProcResult result = new BaseProcResult();
- List<String> titleNames = Lists.newArrayList();
- titleNames.add("BucketIndex");
+ List<String> titleNames = Lists.newArrayList("BucketIndex",
"BackendIds");
int bucketNum = 0;
Review Comment:
This proc node is also used in local mode, so changing the schema
unconditionally from one column per tag to a single `BackendIds` column breaks
existing local colocate group detail output. For example, a non-cloud group
with multiple backend tags used to return columns like `BucketIndex`, `<tag1>`,
`<tag2>` and each row kept backend ids separated by tag; after this change the
tag names are lost and all backends are merged. The PR states local behavior is
unchanged, so please keep the original tag-based output for normal
`getBackendsPerBucketSeq()` results and only use the two-column `BackendIds`
format for the cloud fallback/no-tag case, with a local-mode test covering the
old format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
