morrySnow commented on code in PR #63892:
URL: https://github.com/apache/doris/pull/63892#discussion_r3323202899


##########
fe/fe-core/src/test/java/org/apache/doris/nereids/rules/rewrite/PushDownJoinOnAssertNumRowsTest.java:
##########
@@ -253,6 +254,70 @@ void testPushDownWithProjectNode() {
                                                         logicalOlapScan())));
     }
 
+    /**
+     * Test push down when the top join condition uses an alias from the right 
child
+     * of the bottom join. This covers the DORIS-26089 shape:

Review Comment:
   已去掉 Jira 编号。



##########
fe/fe-core/src/test/java/org/apache/doris/nereids/rules/rewrite/PushDownJoinOnAssertNumRowsTest.java:
##########
@@ -253,6 +254,70 @@ void testPushDownWithProjectNode() {
                                                         logicalOlapScan())));
     }
 
+    /**
+     * Test push down when the top join condition uses an alias from the right 
child
+     * of the bottom join. This covers the DORIS-26089 shape:
+     *
+     * Before:
+     * topJoin(rhs_score < x)
+     * |-- Project(T1.id, T2.cid + 1 as rhs_score, ...)
+     * | `-- bottomJoin(T1.id = T2.sid)
+     * | |-- Scan(T1)
+     * | `-- Scan(T2)
+     * `-- LogicalAssertNumRows(output=(x, ...))
+     *
+     * After:
+     * Project(...)

Review Comment:
   已修正 plan tree 的缩进。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to