github-actions[bot] commented on code in PR #15321:
URL: https://github.com/apache/doris/pull/15321#discussion_r1056204493


##########
be/src/vec/exec/scan/vscanner.h:
##########
@@ -64,6 +64,10 @@ class VScanner {
 public:
     VScanNode* get_parent() { return _parent; }
 
+    int64_t get_time_cost_ns() { return _per_scanner_timer; }

Review Comment:
   warning: method 'get_time_cost_ns' can be made const 
[readability-make-member-function-const]
   
   ```suggestion
       int64_t get_time_cost_ns() const { return _per_scanner_timer; }
   ```
   



##########
be/src/vec/exec/scan/vscanner.h:
##########
@@ -64,6 +64,10 @@
 public:
     VScanNode* get_parent() { return _parent; }
 
+    int64_t get_time_cost_ns() { return _per_scanner_timer; }
+
+    int64_t get_rows_read() { return _num_rows_read; }

Review Comment:
   warning: method 'get_rows_read' can be made const 
[readability-make-member-function-const]
   
   ```suggestion
       int64_t get_rows_read() const { return _num_rows_read; }
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to