TsukiokaKogane commented on code in PR #63850:
URL: https://github.com/apache/doris/pull/63850#discussion_r3338514571
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/stream/BaseTableStream.java:
##########
@@ -57,12 +60,26 @@ public static StreamConsumeType getType(String typeName) {
return UNKNOWN;
}
}
+
+ public static TBinlogScanType toThrift(StreamScanType streamScanType) {
+ switch (streamScanType) {
+ case DEFAULT:
+ case MIN_DELTA:
+ return TBinlogScanType.MIN_DELTA;
Review Comment:
okay let's remove DEFAULT, and use MIN_DELTA default for mow table and
APPEND_ONLY for dup table, and forbid dup table to use MIN_DELTA as there are
no aggregates for dup table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
