HappenLee commented on code in PR #64008:
URL: https://github.com/apache/doris/pull/64008#discussion_r3339995466
##########
be/src/exprs/aggregate/aggregate_function_percentile.h:
##########
@@ -56,10 +56,10 @@ struct PercentileApproxState {
void init(double quantile, float compression = 10000) {
if (!init_flag) {
//https://doris.apache.org/zh-CN/sql-reference/sql-functions/aggregate-functions/percentile_approx.html#description
- //The compression parameter setting range is [2048, 10000].
Review Comment:
BE 范围 [100, 10000] 与 FE session 变量描述 [1000, 10000]
不一致,这里我建议就别加这个FE的开关了，这个感觉很奇怪，默认就是用参数就可以了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
