github-actions[bot] commented on code in PR #64035:
URL: https://github.com/apache/doris/pull/64035#discussion_r3347157354
##########
regression-test/framework/src/main/groovy/org/apache/doris/regression/suite/Suite.groovy:
##########
@@ -2024,10 +2024,12 @@ class Suite implements GroovyInterceptable {
DebugPoint GetDebugPoint() {
def execType = RegressionTest.getGroupExecType(group);
+ // Allow debug points in the external pipeline for JDBC profile cases
that require external dependencies.
if (execType != RegressionTest.GroupExecType.SINGLE
- && execType != RegressionTest.GroupExecType.DOCKER) {
- throw new Exception("Debug point must use in nonConcurrent suite
or docker suite, "
- + "need add 'nonConcurrent' or 'docker' to suite's belong
groups, "
+ && execType != RegressionTest.GroupExecType.DOCKER
+ && !group.split(',').collect { it.trim() }.contains("external")) {
Review Comment:
This makes debug points usable from every suite tagged `external`, but
`external` suites still run as `GroupExecType.NORMAL` and are scheduled on the
shared `suiteParallel` executor (default 10). The new JDBC profile test enables
a global FE debug point that sleeps 10s in
`PluginDrivenExternalTable.initSchema`, so while this suite is running any
other concurrent external JDBC suite can unexpectedly hit the same delay, and
this suite can also disable the point while another debug-point external suite
is still relying on it. That is the race the previous `nonConcurrent`/`docker`
guard was preventing. Please keep this suite isolated, e.g. tag the new test
`nonConcurrent,external` and leave `GetDebugPoint()` restricted to
`SINGLE`/`DOCKER`, or add a genuinely isolated external executor instead of
allowing all normal external suites to use global debug points.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
