Kikyou1997 commented on code in PR #15322:
URL: https://github.com/apache/doris/pull/15322#discussion_r1057095560
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/EliminateGroupByConstant.java:
##########
@@ -50,12 +50,18 @@ public Rule build() {
List<Expression> groupByExprs = aggregate.getGroupByExpressions();
List<NamedExpression> outputExprs =
aggregate.getOutputExpressions();
Set<Expression> slotGroupByExprs = Sets.newLinkedHashSet();
+ Expression lit = null;
for (Expression expression : groupByExprs) {
expression = FoldConstantRule.INSTANCE.rewrite(expression);
if (!(expression instanceof Literal)) {
slotGroupByExprs.add(expression);
+ } else {
+ lit = expression;
}
}
+ if (slotGroupByExprs.isEmpty() && lit != null) {
+ slotGroupByExprs.add(lit);
+ }
Review Comment:
和旧优化器保持一致，否则BE处理上会出问题
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
