HappenLee commented on code in PR #63309:
URL: https://github.com/apache/doris/pull/63309#discussion_r3361065870
##########
be/src/util/jsonb_parser_simd.h:
##########
@@ -95,13 +84,20 @@ struct JsonbParser {
// simdjson process top level primitive types specially
// so some repeated code here
+ bool need_check_at_end = true;
switch (doc.type()) {
case simdjson::ondemand::json_type::object:
case simdjson::ondemand::json_type::array: {
RETURN_IF_ERROR(parse(doc.get_value(), writer));
break;
}
case simdjson::ondemand::json_type::null: {
+ bool is_null = false;
+ simdjson::error_code res = doc.is_null().get(is_null);
+ if (res != simdjson::SUCCESS || !is_null) {
+ return Status::InvalidArgument(fmt::format("simdjson get
null failed: {}",
Review Comment:
如果is_null是false， 可能返回这个报错：· simdjson get null failed: SUCCESS 这个我觉得不太合理
.这个报错信息要改进一下
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
