TsukiokaKogane commented on code in PR #63850:
URL: https://github.com/apache/doris/pull/63850#discussion_r3361788001
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalOlapTableStreamScan.java:
##########
@@ -105,29 +118,31 @@ public LogicalOlapTableStreamScan
withManuallySpecifiedTabletIds(List<Long> manu
return AbstractPlan.copyWithSameId(this, () ->
new LogicalOlapTableStreamScan(relationId, (Table) table,
qualifier,
Optional.empty(), Optional.of(getLogicalProperties()),
- selectedPartitionIds, partitionPruned,
selectedTabletIds,
+ selectedPartitionIds, partitionPruned,
hasPartitionPredicate, selectedTabletIds,
selectedIndexId, indexSelected, preAggStatus,
manuallySpecifiedPartitions,
hints, cacheSlotWithSlotName, cachedOutput,
tableSample, directMvScan,
colToSubPathsMap, manuallySpecifiedTabletIds,
operativeSlots, virtualColumns,
scoreOrderKeys, scoreLimit, scoreRangeInfo,
annOrderKeys, annLimit, tableAlias,
- isIncrementalScan));
+ partitionPrunablePredicates, changeScanInfo,
isNormalized, isIncrementalScan));
}
@Override
public List<Slot> computeOutput() {
if (cachedOutput.isPresent()) {
return cachedOutput.get();
}
- // we need to create slots vectorized for stream scan, no need for
invisible column
- // todo(TsukiokaKogane): support compute binlog-based schema
- List<Column> baseSchema = table.getBaseSchema(false);
+ List<Column> baseSchema =
table.getBaseSchema(changeScanInfo.isPresent());
List<SlotReference> slotFromColumn = createSlotsVectorized(baseSchema);
ImmutableList.Builder<Slot> slots = ImmutableList.builder();
IdGenerator<ExprId> exprIdGenerator =
StatementScopeIdGenerator.getExprIdGenerator();
for (int i = 0; i < baseSchema.size(); i++) {
+ // skip binlog before column
final int index = i;
Column col = baseSchema.get(i);
+ if (col.getName().startsWith(Column.BINLOG_BEFORE_PREFIX)) {
Review Comment:
这块要不留给binlog去改？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
